search

grammyjs / grammY

The Telegram Bot Framework.
https://grammy.dev
MIT License
2.28k stars 112 forks source link

fix: avoid top-level await #545

Closed KnorpelSenf closed 6 months ago

KnorpelSenf commented 7 months ago

Dropping the only instance of TLA

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.08%. Comparing base (c79df4a) to head (018210c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #545 +/- ## ======================================= Coverage 46.08% 46.08% ======================================= Files 19 19 Lines 6052 6052 Branches 320 320 ======================================= Hits 2789 2789 Misses 3260 3260 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KnorpelSenf commented 6 months ago

This is more complicated than I thought, and the benefits are small. I will abandon this.

KnightNiwrem commented 6 months ago

What happened?

KnorpelSenf commented 6 months ago

TLA is not supported on all platforms, querySync is not supported on all platforms, and if we migrate to JSR, we will have to unify all the platform-specific code anyway. I don't see a lot of value in figuring out a good short-term solution here.