Closed KnorpelSenf closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 46.07%. Comparing base (
38efc3c
) to head (8598b02
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@all-contributors add @kolay-v for review
@KnorpelSenf
@kolay-v already contributed before to review
Oh
Awesome
The mapped type
AliasProps
prevents us from leveraging the improvements in https://github.com/microsoft/TypeScript/pull/57871. Hence, even though https://github.com/microsoft/TypeScript/issues/57863 was fixed as a consequence of #543, we are still seeing problems like #551 appear usingtypescript@next
.This PQ removes the helper type and inlines its functionality into the existing collection of
Shortcuts
. In addition to fixing #551, this removes complexity and improves consistency. However, it reduces code reuse a little bit, which is acceptable.You can only test these changes on Node, since Deno does not ship with
typescript@next
yet, which you need to install. You can try out these changes withnpm install github:grammyjs/grammY#avoid-mapped-type
as usual.Closes #551.