Closed fwqaaq closed 4 months ago
Hey, @roj1512 and @KnorpelSenf, I just tried it out. Using Deno std throudh JSR works perfectly fine, and VSCode Deno plugin also support it.
Hey, @roj1512 and @KnorpelSenf, I just tried it out. Using Deno std throudh JSR works perfectly fine, and VSCode Deno plugin also support it.
That was never the question :)
@fwqaaq the tests are failing, something is broken with using
. Can you fix this up?
We use other deprecated methods in the tests that cover input files. Do you want to adjust the tests in the same pull request, or should this be done at a later point?
Attention: Patch coverage is 85.71429%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 45.76%. Comparing base (
4cb8e68
) to head (a8beede
).:exclamation: Current head a8beede differs from pull request most recent head 78662fd. Consider uploading reports for the commit 78662fd to get more accurate results
Files | Patch % | Lines |
---|---|---|
src/types.deno.ts | 85.71% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM otherwise, thanks for the patience during these many iterations!
@fwqaaq please consider signing your commits in the future. I'll ignore this for now and merge anyway :)
Thanks bro, I remember it.😉
@all-contributors add @fwqaaq for idea, code
@KnorpelSenf
I've put up a pull request to add @fwqaaq! :tada:
iterateReader
was deprecated. See: https://deno.land/std@0.211.0/streams/iterate_reader.ts?s=iterateReader.Deno.open
need to release resources. Deno providedusing
keywords for this purpose. Like this: https://github.com/denoland/deno/blob/08f46ac4467968f53400c4cf9db95f62b424a161/cli/tsc/dts/lib.deno.ns.d.ts#L1891importMaps
, it would be more convenient, ifgrammy
andgrammy_type
were to be published JSR. (Like:deno add
)