search

grammyjs / grammY

The Telegram Bot Framework.
https://grammy.dev
MIT License
2.04k stars 106 forks source link

chore(ci): type-check library in CI #586

Closed KnorpelSenf closed 2 months ago

KnorpelSenf commented 2 months ago

How did we never type-check grammY in CI? It currently fails and I only discovered this locally.

winstxnhdw commented 2 months ago

Do we have to add /// <reference types="npm:@types/node" /> in here as well? I always assumed deno task test also type-checks grammY, or at least it seems like it does since it fails whenever I make any type errors that are also not runtime errors.

KnorpelSenf commented 2 months ago

I assumed the same thing. It might only check test files, not all modules under test.

I don't think we can use triple-slash directives here because that would pollute the global types at runtime. We have to find a different way.

winstxnhdw commented 2 months ago

Ok, let me handle this.