search

grammyjs / i18n

Internationalization for grammY powered by Fluent.
https://grammy.dev/plugins/i18n
MIT License
30 stars 5 forks source link

Fluent dependencies are bundled on Node instead of being added to dependencies #29

Closed Loskir closed 1 year ago

Loskir commented 2 years ago
image
dcdunkan commented 2 years ago

Did you mean, we're transforming better_fluent to node instead of using moebius/fluent as the node dependency? If that's the case, it is because the @moebius/fluent package has no synchronous method for adding translations, which i18n uses internally (we had a discussion about it, iirc). better_fluent has sync methods.

Loskir commented 2 years ago

We can release better_fluent on npm My main concern is that if I need to import something from better_fluent I have to import it from some internal thing in i18n. Re-exporting better_fluent more cleanly would also work