search

grammyjs / storage-denodb

DenoDB database storage adapter for grammY
GNU General Public License v3.0
3 stars 0 forks source link

Maintain library #2

Closed Satont closed 2 years ago

KnorpelSenf commented 2 years ago

Sorry, just saw I did not follow your commit convention. Feel free to squash-merge in the end.

Let me know when you consider this ready to be merged, I'll review again and leave an approval.

Satont commented 2 years ago

Sorry, just saw I did not follow your commit convention. Feel free to squash-merge in the end.

It's ok. Lest do not squash to see history of changes.

Let me know when you consider this ready to be merged, I'll review again and leave an approval.

I think it's ready to be merged, and i'm planning to add more database tests engines soon, but not in that PR.

Satont commented 2 years ago

@KnorpelSenf by the way, what do you think about first release version? How it should be? And do you want to publish yourself, or should I?

KnorpelSenf commented 2 years ago

This looks ready for a 1.0 release to me. You can merge and then can release it yourself. This is your package now and you have the last word on things here, in particular regarding releases :)