grammyjs / storages

Storage adapters for grammY sessions.
48 stars 23 forks source link

feat(s3): add S3Storage adapter #220

Open karfau opened 1 month ago

karfau commented 1 month ago

https://pnpm.io/workspaces#referencing-workspace-packages-through-aliases https://jsr.io/docs/npm-compatibility

Satont commented 1 month ago

Thanks for contribution.

You can unignore .npmrc and make necessary changes.

But i'm not sure what to do with storage/utils since it's a helper package which doesn't implies publishing it somewhere. Does it have solution? I'm not familiar with jsr.

karfau commented 1 month ago

I will see what I can find regarding the issues with jsr and pnpm workspaces. But can you tell me which version of pnpm to use? The current lockfile has version 6. when I user the latest pnpm it upgrades it to version 9 and has tons of changes...

Would it make sense to set the package manager version in package.json, so it can simply be installed using corepack enable?

Satont commented 1 month ago

I will see what I can find regarding the issues with jsr and pnpm workspaces. But can you tell me which version of pnpm to use? The current lockfile has version 6. when I user the latest pnpm it upgrades it to version 9 and has tons of changes...

Would it make sense to set the package manager version in package.json, so it can simply be installed using corepack enable?

yea i guess it need to be updated to pnpm 9 version, i'll add changes to main branch. Thanks for pointing it.

karfau commented 1 month ago

I did see that the check failed, might only be able to take care of it next week

karfau commented 1 month ago

@Satont I was able to resolve all todos in the code and I think I also managed to cater for all your comments.

If there is anything else required for the PR to land, let me know.

karfau commented 2 weeks ago

Is there an ETA for landing/reviewing this PR, or is there anything I can do to support that it happens?