search

grammyjs / storages

Storage adapters for grammY sessions.
48 stars 23 forks source link

supabase adapter doesn't work with `supabase^2.43.1` #223

Open thecoorum opened 1 month ago

thecoorum commented 1 month ago

While trying to install the supabase storage adapter it fails with Could not resolve dependency: peer @supabase/supabase-js@"^1.0.0" from @grammyjs/storage-supabase@2.4.2

KnorpelSenf commented 1 month ago

We just need to update https://github.com/grammyjs/storages/blob/f5af10d8b9138e59fbf7123b7feb1007465499df/packages/supabase/package.json#L43 and make sure that the adapter still works after that. Do you feel like opening a pull request for this?

thecoorum commented 1 month ago

Yeah, will do!

thecoorum commented 1 month ago

@KnorpelSenf are there any additional checks except for lerna tests to verify that bumping the dev dependency actually works?

KnorpelSenf commented 1 month ago

I think the best way is if you try your changes in your own bot project and check that everything works as expected for you. This manual testing in addition to passing unit tests and type checks is definitely good enough.

thecoorum commented 1 month ago

I initially installed it with npm i --force (I know that it's not the best solution, the patch-package was not the way here as it's done after install) and the bot is working correctly with grammy/web on Vercel edge function

thecoorum commented 1 month ago

Here is the PR to allow ^2 of supabase as peer dependency - https://github.com/grammyjs/storages/pull/224