Closed habemuscode closed 2 years ago
I will have to buy more build minutes on Netlify if every change to the site causes three articles to be updated. Or maybe we can trigger deploy previews manually, I will investigate this. cc @WingLim
See #142
See #142
UwU ✨
Wouldn’t it be better if the tasks were like
- [ ] #141
- [ ] #142
How would you determine the numbers before creating the full requests? This issue started out without any performed translations, no?
I mean doing that for the open PRs only.
Done, thanks for the advice, its more clear @roj1512
@habemuscode it's sad to see the translations stalling :(
You put a lot of effort into this, I'm surprised that no one is volunteering to review your work. It's slowly getting out of sync, I'm not sure if anyone still has an overview over which things are up to date.
@habemuscode @roj1512 what's your take on how we should proceed from here so that we don't eventually need to close all PQs unmerged?
@habemuscode We’re unhappy to know the fact that you have left us for a while now.
We’ve decided to close the Spanish translation PRs, along with this tracker.
We would also like you to know that this action does not mean that all your efforts will be gone. It is more of a recognition of the inactievness of the Spanish translation process.
None of your branches will be touched, either, so they can be used again, reviewed, or at least taken as a reference if the process started again someday.
@habemuscode https://github.com/grammyjs/website/blob/feat/spanish-translations/site/docs/es/guide/middleware.md is outdated, too. It is missing some examples.
@roj1512 New PR for es/guide/middleware
added created, updated and added here to be tracked.
@habemuscode Do you think you should have the headings (#) in Title Case?
@habemuscode Here are the new pages, in case you need them:
@habemuscode Here are the new pages, in case you need them:
* resources * resources/about.md * hosting * hosting/vps.md * plugins * plugins/emoji.md * plugins/fluent.md * plugins/guide.md * plugins/middlewares.md
Thanks, created new PRs!
Is there a pull request to translate the navigation bar yet?
Is there a pull request to translate the navigation bar yet?
Nope, that things included config, etc. will be after pushed in the PR of feat/spanish-translations
, so we can check everything works. At least, is my plan, but tell me suggestions :)
How do you check if everything works if there is not a good way to navigate?
As long as everything is contained in the translation branch before the changes go live, the plan will work. The order in which the pull requests are merged does not really matter. If there are links in the navigation which point to pages that do not exist, then this is not a problem. Clicking them will simply lead to a 404. As soon as the other pull requests are merged which add these pages, everything will work just fine.
@habemuscode I created #351 so that it will be easier for you to configure things correctly. Now you can focus on the actual translations, rather than the configuration file format.
A little suggestion to add the following key to Spanish. https://github.com/grammyjs/website/blob/9d8b017e8ebd2ec77a4a9a684efe42e355a4bcc4/site/docs/.vuepress/config.ts#L716
Good idea! /cc @habemuscode
I discovered most of the anchor links are broken on the Spanish pages. I think we should review all the pages once again.
English
Description
I want to collaborate
Note
Words related to methods, function names, variables... mustn't be translated. Here are some examples:
Español
Descripción
Me gustaría colaborar
Nota
Palabras relativas a métodos, nombres de funciones, variables... no se traducen. Aquí algunos ejemplos:
Readme
Advanced
Demo
Guide
Hosting
Plugins
Resources