grammyjs / website

The grammY documentation website.
https://grammy.dev
MIT License
43 stars 101 forks source link

Spanish translation tracking #135

Closed habemuscode closed 2 years ago

habemuscode commented 2 years ago

English

Description

I want to collaborate

  1. Being a translator
  1. Being a reviewer

Note

Words related to methods, function names, variables... mustn't be translated. Here are some examples:


Español

Descripción

Me gustaría colaborar

  1. Como traductor
  1. Como validador

Nota

Palabras relativas a métodos, nombres de funciones, variables... no se traducen. Aquí algunos ejemplos:


Readme

Advanced

Demo

Guide

Hosting

Plugins

Resources

KnorpelSenf commented 2 years ago

I will have to buy more build minutes on Netlify if every change to the site causes three articles to be updated. Or maybe we can trigger deploy previews manually, I will investigate this. cc @WingLim

KnorpelSenf commented 2 years ago

See #142

rojvv commented 2 years ago

See #142

UwU ✨

rojvv commented 2 years ago

Wouldn’t it be better if the tasks were like

- [ ] #141 
- [ ] #142
KnorpelSenf commented 2 years ago

How would you determine the numbers before creating the full requests? This issue started out without any performed translations, no?

rojvv commented 2 years ago

I mean doing that for the open PRs only.

habemuscode commented 2 years ago

Done, thanks for the advice, its more clear @roj1512

KnorpelSenf commented 2 years ago

@habemuscode it's sad to see the translations stalling :(

You put a lot of effort into this, I'm surprised that no one is volunteering to review your work. It's slowly getting out of sync, I'm not sure if anyone still has an overview over which things are up to date.

@habemuscode @roj1512 what's your take on how we should proceed from here so that we don't eventually need to close all PQs unmerged?

rojvv commented 2 years ago

@KnorpelSenf Let’s give him some time (max 5 days) to respond to this.

rojvv commented 2 years ago

@habemuscode We’re unhappy to know the fact that you have left us for a while now.

We’ve decided to close the Spanish translation PRs, along with this tracker.

We would also like you to know that this action does not mean that all your efforts will be gone. It is more of a recognition of the inactievness of the Spanish translation process.

None of your branches will be touched, either, so they can be used again, reviewed, or at least taken as a reference if the process started again someday.

rojvv commented 2 years ago

@habemuscode https://github.com/grammyjs/website/blob/feat/spanish-translations/site/docs/es/guide/middleware.md is outdated, too. It is missing some examples.

habemuscode commented 2 years ago

@roj1512 New PR for es/guide/middleware added created, updated and added here to be tracked.

rojvv commented 2 years ago

@habemuscode Do you think you should have the headings (#) in Title Case?

rojvv commented 2 years ago

@habemuscode Here are the new pages, in case you need them:

habemuscode commented 2 years ago

@habemuscode Here are the new pages, in case you need them:

* resources

  * resources/about.md

* hosting

  * hosting/vps.md

* plugins

  * plugins/emoji.md
  * plugins/fluent.md
  * plugins/guide.md
  * plugins/middlewares.md

Thanks, created new PRs!

KnorpelSenf commented 2 years ago

Is there a pull request to translate the navigation bar yet?

habemuscode commented 2 years ago

Is there a pull request to translate the navigation bar yet?

Nope, that things included config, etc. will be after pushed in the PR of feat/spanish-translations, so we can check everything works. At least, is my plan, but tell me suggestions :)

rojvv commented 2 years ago

How do you check if everything works if there is not a good way to navigate?

KnorpelSenf commented 2 years ago

As long as everything is contained in the translation branch before the changes go live, the plan will work. The order in which the pull requests are merged does not really matter. If there are links in the navigation which point to pages that do not exist, then this is not a problem. Clicking them will simply lead to a 404. As soon as the other pull requests are merged which add these pages, everything will work just fine.

KnorpelSenf commented 2 years ago

@habemuscode I created #351 so that it will be easier for you to configure things correctly. Now you can focus on the actual translations, rather than the configuration file format.

quadratz commented 2 years ago

A little suggestion to add the following key to Spanish. https://github.com/grammyjs/website/blob/9d8b017e8ebd2ec77a4a9a684efe42e355a4bcc4/site/docs/.vuepress/config.ts#L716

KnorpelSenf commented 2 years ago

Good idea! /cc @habemuscode

quadratz commented 2 years ago

I discovered most of the anchor links are broken on the Spanish pages. I think we should review all the pages once again.