search

gramps-project / flatpak

Manifest and data files required to make a Gramps Flatpak
3 stars 4 forks source link

exiv2 and gexiv dependencies break ARM64 compatibility #9

Closed OzarkShepherd closed 3 years ago

OzarkShepherd commented 3 years ago

I couldn't figure out what I did wrong in trying to patch exiv2 to work on ARM64 when submitting the flatpak.

  @hfiguiere hfiguiere 2 days ago

0.27.3 also need some patches to build on aarch64. (there are already upstream)

Darktable includes these two:

https://github.com/flathub/org.darktable.Darktable/blob/master/exiv2-arch-flags.patch
https://github.com/flathub/org.darktable.Darktable/blob/master/exiv2-arch-flags-2.patch

in order.
@OzarkShepherd OzarkShepherd 23 hours ago Author

Thank you. I copied and pasted the patches into my github as a test and added them to the manifest. The url of exiv2 we use looks the same to me. However, using the patches breaks the build, and I don't understand patches well enough to modify them myself. How important is it for arch64 to be supported?

[https://github.com/OzarkShepherd/flatpak/runs/1614006445?check_suite_focus=true]

    Building module exiv2Dependency in /home/runner/work/flatpak/flatpak/.flatpak-builder/build/exiv2Dependency-1

    Applying patch exiv2-arch-flags.patch
    patching file cmake/compilerFlags.cmake
    Hunk #1 FAILED at 26 (different line endings).
    1 out of 1 hunk FAILED -- saving rejects to file cmake/compilerFlags.cmake.rej
    Error: module exiv2Dependency: Child process exited with code 1
    Error: Process completed with exit code 1.
OzarkShepherd commented 3 years ago

It works now, I was using the clipboard to copy and paste, but should have been downloading the RAW format to get the line endings without being altered by the clipboard.