search

gramps-project / gramps-web

Frontend for Gramps Web
https://www.grampsweb.org
GNU Affero General Public License v3.0
379 stars 50 forks source link

The "new attribute" modal for editing a person is too small #470

Open gustavi opened 1 month ago

gustavi commented 1 month ago

Description

The "new attribute" modal for editing a person is too small and hard to use. The select do not display more than 2 full options.

image

How to reproduce

Proposed fixes

  1. Making the modal taller
  2. Allow the select to go beyond the modal

Additional information

DavidMStraub commented 1 month ago

Right. But no need to enlarge the modal, just need to set fixedMenuPosition on the mwc-select.

DavidMStraub commented 1 month ago

Turns out this can't be fixed easily with MWC, see https://github.com/material-components/material-web/issues/832.

The solution is to migrate to md-filled-select which has a menuPositioning attribute, see https://material-web.dev/components/select/. But is more work.

DavidMStraub commented 4 weeks ago

Also true for place types:

https://github.com/gramps-project/gramps-web/issues/481#issuecomment-2277871730

m-breitbach commented 4 weeks ago

I observed that, if the dropdown menu opens downwards and is truncated, the whole modal can be scrolled down (this makes it usable at least, even if not super conveniently). In cases where it openes upwards and is truncated (like in place types), no such scrolling becomes availabe.