Incorrect test_efield.root downloaded in #59 Dev_dc1_merge

[lwpiotr]

Regarding #59

After executing source env/setup.sh, the script downloads and unpacks grand_model_2304.tar.gz, which contains an older version of test_efield.root. The downloaded tra.gz must be updated to contain a compatible test_efield.root. Actually, I don't know where to get the compatible one.

[luckyjim]

Hello,

If it is necessary to redo the tar, I also noted the presence of a hidden file (._xxx) almost empty with the same name of the model files and also .DS_Store files

(grandlib-root) jcolley@lpnlp202113:~/projet/grand_wk/merge/grand/data/detector$ ls -la
total 728944
drwxr-xr-x 6 jcolley jcolley      4096 avril  7 08:14 .
drwxrwxr-x 6 jcolley jcolley      4096 mai    5 14:55 ..
-rwxr-xr-x 1 jcolley jcolley       187 juin  28  2022 ._antennaVSWR
drwxr-xr-x 2 jcolley jcolley      4096 juin  28  2022 antennaVSWR
-rwxr-xr-x 1 jcolley jcolley       187 mars   8 04:54 ._cableparameter
drwxr-xr-x 2 jcolley jcolley      4096 mars   8 04:54 cableparameter
-rw-r--r-- 1 jcolley jcolley       120 avril  7 08:14 ._.DS_Store
-rw-r--r-- 1 jcolley jcolley      6148 avril  7 08:14 .DS_Store
-rwxr-xr-x 1 jcolley jcolley       187 juin  28  2022 ._filterparameter
drwxr-xr-x 2 jcolley jcolley      4096 juin  28  2022 filterparameter
-rw-r--r-- 1 jcolley jcolley       187 juil.  2  2022 ._HorizonAntenna_EWarm_leff_loaded.npy
-rw-r--r-- 1 jcolley jcolley 132560144 juil.  2  2022 HorizonAntenna_EWarm_leff_loaded.npy
-rw-r--r-- 1 jcolley jcolley       187 juil.  2  2022 ._HorizonAntenna_SNarm_leff_loaded.npy
-rw-r--r-- 1 jcolley jcolley 132560144 juil.  2  2022 HorizonAntenna_SNarm_leff_loaded.npy

[lwpiotr]

Yeah, these are MacOSX rubbish files, they should be removed.

[lwpiotr]

Btw. in the future, for the next pull requests, I would split the file. The ROOT format and the antenna model are independent, so we should not force the user to update both when only one has changed.

[rameshkoirala]

I think this issue is solved with the use of the new test_efield.root file. I will close this issue.

[lwpiotr]

But is it included in the data downloaded by the grandlib download script?