search

grand-mother / radio-simus

GNU Lesser General Public License v3.0
2 stars 4 forks source link

we have 2 inputfromtxt, and both are not very good #7

Open mjtueros opened 5 years ago

mjtueros commented 5 years ago

I noticed that there are two versions of inputfromtxt (one in in_out.py and the other in computevoltage.py) which are not the same and which are both not really working).

Since this is related to getting input drom ZHAireS input file, i will try to provide one. Eventually, it might be better to not use the .inp file for this, but the .sry file, that has the information of what really happened (and not what you wished it happened when you did your .inp file)

I will try to implement a GetZenith(PathtoFile, Convention), GetAzimuth, GetInjectionHeight, GetGroundLevel, GetPrimary and GetEnergy, and a wrapper that returns all of them. If you need something else, let me know.

Convention: GRAND (energy in EeV?), AIRES (energy in GeV)

azilles commented 5 years ago

Hi! One of the next steps is to get rid of the input function in compute voltage and just have one common one in in_out.py (actually I bet that it was due to the clean-up for the hadns-on that this function poped up...) Just the functions which have already documentation are the ones which I tried to clean up. Sure, you can write a script for the sry-files. But it should be in python3.7

niess commented 5 years ago

@mjtueros : not sure what the energy convention is. You could also use explicit units with astropy as:

>>> import astropy.units as u
>>> E = 1 * u.GeV

That would be more consistent with the fore coming grand tools.