search

grandchamp / Identity.Dapper

Identity package that uses Dapper instead EntityFramework for use with .NET Core
MIT License
268 stars 62 forks source link

Preserve connection string when username/password are not in settings #85

Closed ervwalter closed 5 years ago

ervwalter commented 5 years ago

This addresses issue #78.

Now, if no username/password is provided, either because they were blank or because ConnectionStrings:DefaultConnection is being used, the connection string configured is left alone.

This also adds unit tests for the three supported connection providers to validate the above changes.

ervwalter commented 5 years ago

P.S. I just incremented each version number by 1. I assume you don't mind that they are not all in sync with each other.

ervwalter commented 5 years ago

FYI, I just downloaded the new nuget package for Identity.Dapper.SqlServer and noticed that while the package number is now 0.8.3, it still contains the old DLL with file version number 0.8.2 (and without these changes). I know very little about how nuget works behind the scenes, and I don't know how packages get published, but it seems like something went wrong this time?

P.S. I manually downloaded the latest package from https://www.nuget.org/api/v2/package/Identity.Dapper.SqlServer/0.8.3-alpha and unzipped it to confirm that the DLL included is 0.8.2, and that this isn't just a problem with my local copy of the package.

grandchamp commented 5 years ago

I've deployed new packages again, probably it was some cache from my builds. I think now it's right.