search

grandchild / flatcrawler

Get notified via email when certain housing association websites post new flat offers.
Creative Commons Zero v1.0 Universal
15 stars 1 forks source link

Fix key error in "load_config" when loading "site-blocklist" #18

Closed slaufmann closed 3 years ago

slaufmann commented 3 years ago

The site-blocklist is part of the "search" section of config.yaml. It was accessed on the wrong dictionary.

This pull request fixes a tiny error that was introduced by commit ad3b74c3ee721e3f5080d5a55c733d5567f339ff.

grandchild commented 3 years ago

It's not part of the search dict for me, it's in the top level of the config.yaml.

slaufmann commented 3 years ago

Well, we need a tiebreaker then, i guess.

The default config also lists it at the top level. Even though I did not intended it to be that way it might be the better thing to do. Apparently it can lead to mistakes. In the creation I associated the site-blocklist with thesearch settings but one may also consider it a more global configuration.

I should retract my pull request and just fix my config file, what do you think?

grandchild commented 3 years ago

You're right, it does make more sense in the search config. 🙂