grandnode / grandnode2

Open-Source eCommerce Platform on .NET Core, MongoDB, AWS DocumentDB, Azure CosmosDB, LiteDB & Vue.js
https://grandnode.com/
GNU General Public License v3.0
1.06k stars 435 forks source link

Issue-405 : Orders search with OrderNumber field #406

Open SunilParisi123 opened 1 year ago

SunilParisi123 commented 1 year ago

Issue-405 : Orders search with OrderNumber field

Resolves #issueNumber
Type: feature|bugfix|

Issue

Description of the issue this PR is solving, why it's happening, and how to reproduce it.

Solution

Summarize your solution to the problem. Please include short description.

Breaking changes

If you have a breaking changes, list them here, otherwise list none.

Testing

  1. List the steps needed for testing your PR.
  2. Assume that everyone already know how to run the GrandNode, and do the basic configuration.
  3. Be detailed enough that someone can work through it easily.
SunilParisi123 commented 1 year ago

Issue: https://github.com/grandnode/grandnode2/issues/405

Nikhil13x commented 1 year ago

@KrzysztofPajak Can this be included?

SunilParisi123 commented 1 year ago

When we want to Filter the orders using OrderNumber (which customers will be aware of mainly) and this is not part of the search handler. When customer is having multiple orders and want to filter that using OrderNumber currently it's not supported in Order Service (GetOrderHandler). So this PR is for that to extend the search including OrderNumber too.

KrzysztofPajak commented 1 year ago

@Nikhil13x, @SunilParisi123 Interface IOrderService has a method GetOrderByNumber why you don't want to use it ?

SunilParisi123 commented 1 year ago

@Nikhil13x, @SunilParisi123 Interface IOrderService has a method GetOrderByNumber why you don't want to use it ?

@KrzysztofPajak We wanted to show orders as Autocomplete list and wanted to show all the orders starting with the matching number.

KrzysztofPajak commented 1 year ago

@Nikhil13x when you limit to ordernumber you should get only one record. So I would like to recommend to use method GetOrderByNumber