search

grandnode / grandnode2

Open-Source eCommerce Platform on .NET Core, MongoDB, AWS DocumentDB, Azure CosmosDB, LiteDB & Vue.js
https://grandnode.com/
GNU General Public License v3.0
1.09k stars 441 forks source link

form-validation-fixes #408

Closed fareedk2 closed 1 year ago

fareedk2 commented 1 year ago

Resolves #issueNumber
Type: feature|bugfix|

Issue

Description of the issue this PR is solving, why it's happening, and how to reproduce it.

Solution

Summarize your solution to the problem. Please include short description.

Breaking changes

If you have a breaking changes, list them here, otherwise list none.

Testing

  1. List the steps needed for testing your PR.
  2. Assume that everyone already know how to run the GrandNode, and do the basic configuration.
  3. Be detailed enough that someone can work through it easily.
SunilParisi123 commented 1 year ago

When there is a min length validation on a field and when user not overwrite any validation text, currently it's showing the message as "'This ' + fieldName + ' should have at least characters.'". This is not giving the more information on how many characters required as minimum. There can be multiple fields with different Min length requirements. So it's better to have the message explicitly include the Minimum length characters in the error message. This PR is addressing this issue.

SunilParisi123 commented 1 year ago

@KrzysztofPajak Can this be included?

KrzysztofPajak commented 1 year ago

@SunilParisi123 Thanks, yes your PR will be merge