search

granludo / basiclti4moodle

Automatically exported from code.google.com/p/basiclti4moodle
1 stars 0 forks source link

resource_link_id should differ across all instances of a BasicLTI Activity #17

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
1. Create a BasicLTI activity with some data for some Tool Provider
2. Use this activity in multiple places within a course
3. All the BasicLTI links will send the same resource_link_id which is
incorrect; each link placement should have a distinct value for this parameter.

The problem appears to be the assignment of $instance->typeid to this param
in locallib.php's basiclti_build_request() function.  Instead,
$instance->id should perhaps be used.

Original issue reported on code.google.com by joseph.b...@gmail.com on 28 May 2010 at 2:32

GoogleCodeExporter commented 9 years ago 
This was a problem in an earlier version.   The problem is not present in the 
most recent release.  You saw this 
because an old version of the code ended up in a release zip that you used.  
Sorry.

Original comment by drchuck on 30 May 2010 at 9:09