search

grantcarthew / node-rethinkdb-job-queue

A persistent job or task queue backed by RethinkDB.
https://github.com/grantcarthew/node-rethinkdb-job-queue/wiki
MIT License
156 stars 16 forks source link

Should setProgress automatically log change? #29

Closed TomKaltz closed 7 years ago

TomKaltz commented 7 years ago

Should job.setProgress() automatically add a log entry just like the new job.update() functionality?

Should all the job.set*****() methods automatically log the change?

grantcarthew commented 7 years ago

@TomKaltz, you are good at finding nooks and crannies in the project.

Your question prompted me to review the methods. In hind sight, I should change the name of Job.setProgress to Job.updateProgress.

The other set methods are simply changing the properties of the Job, not touching the database. Job.setProgress is the only method that changes the database.

I have created a Project and am adding items that should be reviewed for v2.0. https://github.com/grantcarthew/node-rethinkdb-job-queue/projects/1

Feel free to add to it. I'll close this for now due to the project.

grantcarthew commented 7 years ago

@TomKaltz, Just found out you can't add to projects. Raise new issues if you have any more ideas.

Thanks.

grantcarthew commented 7 years ago

Hi @TomKaltz, I just published v1.1.0 which includes automatic logs for Job.setProgress however I will not rename until v2.