[bug] canceling a job while its active still makes the final status as "completed" rather than "cancelled".

grantcarthew / node-rethinkdb-job-queue

A persistent job or task queue backed by RethinkDB.

https://github.com/grantcarthew/node-rethinkdb-job-queue/wiki

MIT License

157 stars 16 forks source link

[bug] canceling a job while its active still makes the final status as "completed" rather than "cancelled". #82

Closed gkumar9 closed 5 years ago

gkumar9 commented 6 years ago

screenshot from 2018-05-02 13-14-25

grantcarthew commented 6 years ago

This could be either a race condition or mis-configuration @gkumar9 . How many worker nodes do you have? If you cancel the job on one worker node whilst the other node is just finishing the job, it would cause this issue.

gkumar9 commented 6 years ago

I have only one worker @grantcarthew . While listening to events I noticed that first cancelled is called and then completed event gets called.

grantcarthew commented 6 years ago

Sorry @gkumar9, I've been busy working on this: https://github.com/grantcarthew/node-perj I'm not using RethinkDB at the moment so you are going to have to help with the debugging. Is this a repeatable issue?

gkumar9 commented 5 years ago

yes

grantcarthew commented 5 years ago

I'm happy to help you understand the code however I'm working on other projects right now. What tool do you want to use for casual chat? It used to be an easy choice. Not so much now. For instant messaging I use Signal however time zones can cause issues there. There's gitter, slack, etc.