impl: added change-feed reConnection mechanism

grantcarthew / node-rethinkdb-job-queue

A persistent job or task queue backed by RethinkDB.

https://github.com/grantcarthew/node-rethinkdb-job-queue/wiki

MIT License

157 stars 16 forks source link

impl: added change-feed reConnection mechanism #92

Open KrishnaPG opened 3 years ago

KrishnaPG commented 3 years ago

Enables change-feed reconnection when the connection drops.

New reconnect options have been added that expose the pingInterval as well as connection reattempt controls

Note that this reconnection is only limited to the change feeds and other parts of the package, such as dbAssertion etc. still may fail on connection failure.

grantcarthew commented 3 years ago

Hi @KrishnaPG. Sorry for the late reply. This went under my radar for some reason.

I can't see any unit tests added for this change. It looks great otherwise.

Can you add a unit test or two?

grantcarthew commented 3 years ago

On a side note @KrishnaPG, are you interested in becoming a maintainer? Are you a JavaScript ninja? Your profile indicates some level of skill.