search

grantemsley / dokuwiki-plugin-patchpanel

Depreciated in favor of https://github.com/GreenItSolutions/dokuwiki-plugin-switchpanel
6 stars 4 forks source link

change patch numbering order #5

Closed konus1 closed 9 years ago

konus1 commented 10 years ago

There are some switches on the market with a different numbering schema. Instead of 01,02,03,04,05,06,07,08,09,10,11,12 13,14,15,16,17,18,19,20,21,22,23,24

they have 01,03,05,07,09,11,13,15,17,19,21,23 02,04,06,08,10,12,14,16,18,20,22,24 (i.e. HP, Netgear, TP-Link, DLink, Nortel, Force10))

it would be nice, if the plugin could used for them too.

Note: I also found on the net the follwoing numbering schema, but don't know, how common they are: 13,14,15,16,17,18,19,20,21,22,23,24 01,02,03,04,05,06,07,08,09,10,11,12 and 02,04,06,08,10,12,14,16,18,20,22,24 01,03,05,07,09,11,13,15,17,19,21,23 (LevelOne, ZyXEL))

pjahn commented 10 years ago

Ist there an easy workaround to modify the numbering?

konus1 commented 10 years ago

I did not found any. At least it is not EASY to ME.

grantemsley commented 10 years ago

I do intend to add this functionality at some point (hopefully soon!), just been too busy to look at it the last few months.

sebawern commented 10 years ago

I got it working for switches with 2 rows (using the HP, Netgear, TP-Link, DLink, Nortel, Force10 numbering scheme), however, to support switches with more than 2 rows, my patch needs to be rewritten. I'll submit a pull request once i've done that.

grantemsley commented 10 years ago

Perhaps just adding another optional parameter to the port's line to specify the port number would be better?

I can forsee this getting REALLY complex for switches with sfp ports, or 4U chassis switches...

sebawern commented 10 years ago

In my opinion, usability will suffer if there is an additional, optional parameter for each port. I think the best way to approach this is to determine whether the devices is a switch (which means the numbering scheme mentioned above) or a patch panel and change the way the switch/panel is drawn depending on that parameter.

grantemsley commented 10 years ago

That's certainly true. I look forward to seeing your pull request!

konus1 commented 9 years ago

I would like to donate 10 Euro to help solving this feature request. Anyone?

grantemsley commented 9 years ago

I will see if I can find some time to work on it in the next couple days.

sebawern commented 9 years ago

I've submitted my pull request, in my opinion there is no need to do anything except reviewing my patch.

grantemsley commented 9 years ago

Im sorry. Somehow I must have missed the notification about the pull request. I will review it today.

sebawern commented 9 years ago

No problem. If anything needs to be fixed, i can work on it tomorrow. I've been using it since i submitted the pull request without issues.

grantemsley commented 9 years ago

Very sorry it took so long (work and holidays have been keeping me busy!), but I've finally merged your pull request. Thank you for writing it.

konus1 commented 9 years ago

Great! Just drop me a note at patchpanel.9.konus@spamgourmet.com so I can buy both you a beer! If you don't want it, I will donate it to dokuwiki.

grantemsley commented 9 years ago

Fiveninezero did all the hard work - if he wants it all thats fine by me. Otherwise please donate it.

sebawern commented 9 years ago

Well, i don't really care for beer. So ... please donate :)

konus1 commented 9 years ago

OK, I have donated it do dokuwiki. Thank you for your help!