granthnk / hoverzoom

Automatically exported from code.google.com/p/hoverzoom
0 stars 0 forks source link

Warning: event.layerX and event.layerY are broken and deprecated in WebKit #170

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The plugin is resulting in JavaScript warnings in the JS Console on all pages 
with every mouse movement: "event.layerX and event.layerY are broken and 
deprecated in WebKit. They will be removed from the engine in the near future."

As far as I can see this is caused by using an old version of jquery.

Hover Zoom version: 3.2
Google Chrome version: SVN 17.0.923.0 (Developer Build 107881 Linux)
Operating system: Linux

From what I can tell this may cause hoverzoom to stop working fairly soon 
unless jquery is upgraded.

Original issue reported on code.google.com by axll...@gmail.com on 30 Oct 2011 at 4:41

GoogleCodeExporter commented 9 years ago
Thanks for reporting this. I've upgraded Hover Zoom with the last jQuery 
version (1.6.4) and it still uses these features. I guess the Chromium team 
won't remove them too soon if it breaks all sites using jQuery. I'll keep an 
eye on it though.

Original comment by romain.v...@gmail.com on 3 Nov 2011 at 5:22

GoogleCodeExporter commented 9 years ago
jQuery 1.7 was just released and it removes event.layerX and event.layerY.

"We have removed these non-standard properties in version 1.7. Although we 
normally would have gone through a deprecation notice period for these, Chrome 
version 16 generates a flood of console warning messages on the page. Because 
of this, we decided to remove them immediately. On platforms that still support 
these properties, they are available through event.originalEvent.layerX and 
event.originalEvent.layerY."

Original comment by andycouch on 3 Nov 2011 at 9:00

GoogleCodeExporter commented 9 years ago
OK, thanks for the notification. I'll test Hover Zoom with this new version.

Original comment by romain.v...@gmail.com on 3 Nov 2011 at 10:12

GoogleCodeExporter commented 9 years ago
Thanks for the update. Looks like it's a good option to jump to 1.7 then.

Original comment by axll...@gmail.com on 3 Nov 2011 at 10:14

GoogleCodeExporter commented 9 years ago
Issue 177 has been merged into this issue.

Original comment by romain.v...@gmail.com on 7 Nov 2011 at 6:37

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r360.

Original comment by romain.v...@gmail.com on 8 Nov 2011 at 3:02

GoogleCodeExporter commented 9 years ago
Thanks Romain. Any ideas when these changes will be pushed through to the 
Chrome Web Store?

Original comment by axll...@gmail.com on 8 Nov 2011 at 6:20

GoogleCodeExporter commented 9 years ago
I don't know. I'll use Hover Zoom a bit with jQuery 1.7 before releasing it, to 
make sure it doesn't break anything. This shouldn't be too long though.

Original comment by romain.v...@gmail.com on 8 Nov 2011 at 6:27

GoogleCodeExporter commented 9 years ago
The console crashes a lot on my machine due to the huge amount of warnings. Is 
there a hidden setting where we can disable this?

Original comment by emilta...@gmail.com on 11 Nov 2011 at 6:55

GoogleCodeExporter commented 9 years ago
@emilta - you can replace the jquery-min.js file that's in HoverZoom's folder 
with the latest jquery. I did it and it's been working fine. 

Original comment by steve.ba...@gmail.com on 11 Nov 2011 at 7:18