Fix synchronous session connection - Githubissues

grantila / fetch-h2

HTTP/1+2 Fetch API client for Node.js

MIT License

336 stars 16 forks source link

Fix synchronous session connection #15

Closed pietermees closed 6 years ago

pietermees commented 6 years ago

Due to https://github.com/nodejs/node/issues/19839, the http2Connect callback at https://github.com/grantila/fetch-h2/blob/4321b063b84f08d7c2741c338adb5e6802493b80/lib/context.ts#L214 doesn't get called if the session synchronously connected.

grantila commented 6 years ago

Good catch. I'll wait for an upstream fix as of now.

pietermees commented 6 years ago

Fixed by https://github.com/nodejs/node/pull/19842