Closed mcepl closed 2 years ago
Confirmed. This is a blocker for 0.9.0
For me this only happens with the Python 3.7 environment, reproducible locally with tox -e py37
Notice the draft PR in #73
What is super weird is that the test suite only fails with Python 3.6 and 3.7, and there only with --check
and not --diff
. Even stranger, if you activate the py36
or py37
venvs and run blue
from the command line, either with --check
or --diff
it works.
Because the resulting coverage lines are different, my suspicion is that we need to monkey patch things differently for Python < 3.8, but I don't have any other ideas more than that.
I'm stalled, and I'm pretty tempted to get out of this by just dropping Python 3.6 and 3.8! What do you think @grantjenks
@warsaw I took a look following your mention of this issue and I think I figured it out. It's a fun one, the perfect storm of a couple things. Find me at pycon!
@hauntsaninja Oh I can't wait! I have a thing this morning but I'll come find you afterward.
Thank you.
When packaging for openSUSE (after applying all patches from #66, so that is not the issue) I get these errors:
Complete build log with all packages used and steps taken.
What is the most interesting (in my opinion) is that
list_comments()
function (if I am not mistaken) own function of this package, so it is strange that tests call it incorrectly. Also, it is strange, that I cannot find the wordpreview
in the exploded packages.Whatβs going on, please?