search

grantjenks / py-tree-sitter-languages

Binary Python wheels for all tree sitter languages.
Other
149 stars 43 forks source link

Support more languages #33

Closed Freed-Wu closed 7 months ago

Freed-Wu commented 11 months ago

Fix #32

grantjenks commented 11 months ago

Look at the past merges. You have to change more than repos.txt

Freed-Wu commented 11 months ago

Update build.py

grantjenks commented 11 months ago

Also the readme and the tests.

Freed-Wu commented 11 months ago

Updated

Freed-Wu commented 11 months ago

Related discussion: https://github.com/nvim-treesitter/nvim-treesitter/discussions/5588

Freed-Wu commented 10 months ago

@grantjenks

grantjenks commented 10 months ago

You can’t just delete all the licenses from the readme. Distributing in binary form doesn’t necessarily remove all license restrictions.

Freed-Wu commented 10 months ago

Can we have some method to update license automatically like https://github.com/nvim-treesitter/nvim-treesitter/discussions/5588#discussioncomment-7415038?

Freed-Wu commented 10 months ago

You can’t just delete all the licenses from the readme.

I have added the licenses.

Distributing in binary form doesn’t necessarily remove all license restrictions.

nvim-treesitter doesn't add any license in README. Is it necessary?

Freed-Wu commented 10 months ago

@grantjenks

Freed-Wu commented 10 months ago

And, I advise to add a scheduled CI/CD to update the version.

Freed-Wu commented 9 months ago

@grantjenks Any other problem? If you are busy to review this PR, can you add me to collaborators?

grantjenks commented 9 months ago

Looking at the project licenses, I don't think you can add GPL'd code and maintain this project as Apache 2.

ChatGPT thinks so too: https://chat.openai.com/share/fe181dca-6ebc-4965-890e-d8ef20cfcb6b

IANAL

Freed-Wu commented 8 months ago

add GPL'd code and maintain this project as Apache 2.

Where is GPL's code? This project's license shouldn't be changed.

sansmoraxz commented 8 months ago

Could you move the hashes of the subrepo to stable commit (or the commit with latest release attached if possible)? I don't think all of them are stable.

sansmoraxz commented 8 months ago

Also a lot of them are missing src/parser.c. (Written in JS)

Those will fail to build.

Freed-Wu commented 8 months ago

a lot of them are missing src/parser.c

Not sure why missing. Let us delete them before we know why.

Freed-Wu commented 8 months ago

There will need to be an ALLOWLIST of Apache2 compatible software licenses.

How to get the allowlist?

Freed-Wu commented 7 months ago

There are many languages information is stored in https://github.com/nvim-treesitter/nvim-treesitter/blob/master/lua/nvim-treesitter/parsers.lua#L79-L2269 and updated very frequently. We should have a method to extract them to get the latest parsers.

sansmoraxz commented 7 months ago

Is it really a better approach though?

I find locking down to commit id's to be a much more sensible option.