grantjenks / py-tree-sitter-languages

Binary Python wheels for all tree sitter languages.
Other
169 stars 48 forks source link

New release 2.0.0 #46

Closed tancnle closed 10 months ago

tancnle commented 10 months ago

@grantjenks Would it be possible to push a new release of tree_sitter_languages?

Many thanks for your work on this project.

grantjenks commented 10 months ago

Release triggered at https://github.com/grantjenks/py-tree-sitter-languages/actions/runs/7706777756

tancnle commented 10 months ago

Thank you for pushing a new release @grantjenks 🙇🏼

I have noticed that macOS and windows wheels are not available on PyPi. I can see the macOS build was completed successfully but the subsequent upload job did not include them 🤔

tancnle commented 10 months ago

Another data points, the links for the uploaded macOS and windows are both returning 404

tancnle commented 10 months ago

I think both macOS and windows artefacts are overwritten by ubuntu ones because of this change https://github.com/grantjenks/py-tree-sitter-languages/pull/42/commits/bc2ba52151b99ddafd81ddfee14373d2844f6ec9.

tancnle commented 10 months ago

I think reverting back to upload-artifact@v2 would be a quickest fix (https://github.com/grantjenks/py-tree-sitter-languages/pull/47)

grantjenks commented 10 months ago

Try 2 https://github.com/grantjenks/py-tree-sitter-languages/actions/runs/7720774276

tancnle commented 10 months ago

@grantjenks It seems that the build is failing due to artefacts not being found. I think it is due to some compatibility issue between upload-artifact@v2 and download-artifact@v4. 🤔

I have reinstated upload-artifact@v4 (PR) and ensured there are no naming conflicts (following the example from upload-artifact repo). The artefact links are shown up in the log (source).

Screenshot 2024-01-31 at 10 59 20 pm

Hopefully, the upload job will pass this time. Could you kindly have another look? 🙏🏼

andreportela commented 10 months ago

How can I test it on macOS M1?

tancnle commented 10 months ago

@andreportela We need to push a new release so the package with MacOS wheels will be available via PyPi. At the moment, you can download the wheels directly from the artefacts page.

  1. Download wheelhouse-macos-latest and unpack the locally.

  2. Select the appropriate one for your Python version and arch. For example, I use Python 3.11 on M1 so I select tree_sitter_languages-1.10.1-cp311-cp311-macosx_11_0_arm64.whl.

    ./
    tree_sitter_languages-1.10.1-cp310-cp310-macosx_10_9_x86_64.whl
    tree_sitter_languages-1.10.1-cp310-cp310-macosx_11_0_arm64.whl
    tree_sitter_languages-1.10.1-cp311-cp311-macosx_10_9_x86_64.whl
    tree_sitter_languages-1.10.1-cp311-cp311-macosx_11_0_arm64.whl
    tree_sitter_languages-1.10.1-cp312-cp312-macosx_10_9_x86_64.whl
    tree_sitter_languages-1.10.1-cp312-cp312-macosx_11_0_arm64.whl
    tree_sitter_languages-1.10.1-cp37-cp37m-macosx_10_9_x86_64.whl
    tree_sitter_languages-1.10.1-cp38-cp38-macosx_10_9_x86_64.whl
    tree_sitter_languages-1.10.1-cp38-cp38-macosx_11_0_arm64.whl
    tree_sitter_languages-1.10.1-cp39-cp39-macosx_10_9_x86_64.whl
    tree_sitter_languages-1.10.1-cp39-cp39-macosx_11_0_arm64.whl
  3. Install the package

    ❯ pip install tree_sitter_languages-1.10.1-cp311-cp311-macosx_11_0_arm64.whl 
  4. Try it out

     $ python
     Python 3.11.7 (main, Jan 15 2024, 18:10:15) [Clang 15.0.0 (clang-1500.1.0.2.5)] on darwin
    Type "help", "copyright", "credits" or "license" for more information.
     >>> from tree_sitter_languages import get_language, get_parser
     >>> language = get_language('python')
    >>>> parser = get_parser('python')
tancnle commented 10 months ago

👋🏼 @grantjenks would it be possible if you could please push another release or perhaps rebuild/push 1.10.1 🙏🏼?

grantjenks commented 10 months ago

Try 2: https://github.com/grantjenks/py-tree-sitter-languages/actions/runs/7772134775

tancnle commented 10 months ago

Thanks @grantjenks. The new package looks good to me 🙇🏼‍♂️