grantland / android-autofittextview

A TextView that automatically resizes text to fit perfectly within its bounds.
Apache License 2.0
4.27k stars 688 forks source link

Set android:allowBackup="false" to include library #30

Closed cbedoy closed 9 years ago

cbedoy commented 9 years ago

When including your Library in my App I get this error message on gradle build:

Error:(42, 9) Attribute application@allowBackup value=(true) from AndroidManifest.xml:42:9 Error:(42, 9) Execution failed for task ':app:processDebugManifest'.

Manifest merger failed : Attribute application@allowBackup value=(true) from AndroidManifest.xml:42:9 is also present at bills-android:XXXXXX:unspecified:31:9 value=(false) Suggestion: add 'tools:replace="android:allowBackup"' to element at AndroidManifest.xml:41:5 to override

A Library should never set androidBackup=true in it's manifest, please fix.

Thanks and best regards, Bedoy

grantland commented 9 years ago

Is this more of an issues that it's specified or that it's specified as true? It seems to me that this pull request should be removing the line and not changing it, right?