search

grantland / android-autofittextview

A TextView that automatically resizes text to fit perfectly within its bounds.
Apache License 2.0
4.27k stars 688 forks source link

Konradjanica.heightfitting #43

Open KonradJanica opened 9 years ago

KonradJanica commented 9 years ago

https://github.com/grantland/android-autofittextview/issues/19

Adds an option to allow text downsizing to fit height.

See methods:

See members:

Works in project https://github.com/KonradJanica/aMatch

Notes:

P.S. sorry about the entire file change, I think my IDE changed something... I suggest maybe leaving it as a new branch until thoroughly tested.

grantland commented 9 years ago

This would be an awesome feature to add, however, it is very difficult to review as the entire files are shown as changed. Any chance you can update this with correct diffs?

KonradJanica commented 9 years ago

I'll take a look, no guarantees because I'm a bit stretched for time this month. Without thinking I automatically changed tab indenting to 4 space indenting via the android studio prompt. :-(

brcolow commented 8 years ago

Question 1:

This line:

int targetHeight = view.getHeight() - view.getPaddingTop() - view.getPaddingTop();

Should it not be:

int targetHeight = view.getHeight() - view.getPaddingTop() - view.getPaddingBottom();

Question 2:

These two lines:

float textHeight = getTextHeight(text, paint, targetWidth, size);
textHeight = getTextHeight(text, paint, targetWidth, size);

the second line seems redundant, is it not?

shahimclt commented 8 years ago

Hey @grantland. can you merge this please? My specific case needs this badly. Thanks.