search

grantmakers / profiles

Grantmakers.io Profiles - Summary profiles for all US-based foundations who have filed electronic IRS Form 990-PF
MIT License
1 stars 1 forks source link

Microsoft Edge - Algolia does not work #85

Closed chadokruse closed 4 years ago

chadokruse commented 4 years ago

When cross-browser testing via Browserstack, observed profiles are not showing results from Algolia, only the SEO-placeholder-results table.

Low priority: Affects <2.0% of visitors and there is a solid backup in place

The Edge console shows the offending code is: https://github.com/grantmakers/profiles/blob/source/assets/js/search.js#L415

SCRIPT1028: SCRIPT1028: Expected identifier, string, or number search.js (418,13)

Code is taken directly from Algolia docs (link) Able to reproduce error via BrowserStack Microsoft Edge v18 (latest)

Analysis: Spread operator is not supported in Edge (browser compatibility)

Also appears to be a second issue, which appears in BugSnag as Rejection reason was not an Error. See "Promise" tab for more detail.

Seems related to Autocomplete.js

chadokruse commented 4 years ago

Spread operator now supported in latest versions of Edge.