grantmcconnaughey / Lintly

Automated GitHub PR code reviewer for Python, JavaScript, CSS, and more.
MIT License
92 stars 18 forks source link

Lintly requests changes even if no issues were detected #32

Open phrdang opened 4 years ago

phrdang commented 4 years ago

Hello, thank you for making this GitHub action, it's been very useful!

I have the following workflow file:

name: Python (Lintly)

on: pull_request

jobs:
  lint-python:
    name: Lint Python with flake8
    runs-on: ubuntu-latest

    steps:
    - name: Check out Git repository
      uses: actions/checkout@v2

    - name: Set up Python
      uses: actions/setup-python@v1
      with:
        python-version: '3.x'

      # Install flake8 and Lintly
    - name: Install Python dependencies
      run: pip install flake8 lintly

      # Run Lintly with flake8
    - name: Lint with flake8
      run: flake8 | lintly --commit-sha=${{ github.event.pull_request.head.sha }}
      env:
        LINTLY_API_KEY: ${{ secrets.GITHUB_TOKEN }}

Oddly, the action requests changes even though there are no linting issues:

Screen Shot 2020-08-04 at 1 32 27 PM

Any help with this issue or a fix of this bug would be appreciated!

grantmcconnaughey commented 4 years ago

Hey there! Sorry for the late reply; this somehow fell off my radar. Is this PR in a public repo where I could take a look at the output?

phrdang commented 4 years ago

Yep, you can find it here: code4tomorrow/python#39. Brief background on the repository - it's being used as a collection of introductory Python code examples, problems, and solutions. Here's a link to the workflow file as well if you need it; it hasn't changed since I submitted this PR.

abhishekkundalia commented 4 years ago

I am facing the same issue. Please let me know if we found something.