search

grantmcconnaughey / django-field-history

A Django app to track changes to model fields.
BSD 3-Clause "New" or "Revised" License
314 stars 33 forks source link

Provide setting to override object_id type #17

Closed benglazer closed 7 years ago

benglazer commented 7 years ago

Implements a complete solution to #16 by adding a setting to override the field type of FieldHistory.object_id. Preserves TextField as the default field type for backwards compatibility.

See updates to README.rst for more details.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 95.402% when pulling 190f497d9ee3173d750639843f8ad4e82800af41 on benglazer:object-id-type-setting into edf07f3586aab80bf492aabd1ef3d6f9e90454e8 on grantmcconnaughey:master.

benglazer commented 7 years ago

@grantmcconnaughey: Any feedback on this PR, or things you'd like changed to make this viable for merging into master? Grateful for any thoughts from you or other members of the django-field-history community.

grantmcconnaughey commented 7 years ago

Hey @benglazer, sorry for the delay.

I like it. I think this will be handy for users that would prefer to use a different ID field type for their models. I'll get this merged and released to PyPI.

Thanks a lot for taking the time to do this!

grantmcconnaughey commented 7 years ago

django-field-history 0.6.0 is on PyPI now!

benglazer commented 7 years ago

Sweet, thanks @grantmcconnaughey!