Here is three commits to solve #5 issue

grantmcconnaughey / django-field-history

A Django app to track changes to model fields.

BSD 3-Clause "New" or "Revised" License

314 stars 33 forks source link

Here is three commits to solve #5 issue #6

Closed ramusus closed 8 years ago

ramusus commented 8 years ago

made migration compatible with Django 1.7, added index on field_name column
ability to change serialize name in settings: FIELD_HISTORY_SERIALIZER_NAME
added json_nested_serializer for serializing fields from parent model

coveralls commented 8 years ago

Coverage decreased (-33.6%) to 62.215% when pulling c5a1bd1243c25028e286a1b0141b6dd0b6b2fed6 on ramusus:master into f1d4961b8993106a320499407cb9014a7db4e844 on grantmcconnaughey:master.

grantmcconnaughey commented 8 years ago

Nice, lots of improvements here it looks like.

A few things I'd like to see before merging this:

Tests. This took test coverage from 95% to 62%. Let's get that json_nested_serializer.py file completely tested.
Documentation. Add a changelog entry for version 0.5.0 with the changes and put the FIELD_HISTORY_SERIALIZER_NAME setting in the documentation somewhere.

I need to look over it a bit more before giving more feedback, but those two things are a start.

ramusus commented 8 years ago

Ok, agree will update PR

grantmcconnaughey commented 8 years ago

Also, if you want to support Django 1.7.x then put that in .travis.yml so I can confirm all tests pass for it. Support for Django 1.7 ended on December 1, 2015, so I'm not going to do anything to add support for it. But, if you can get it working and it doesn't muddy up the codebase then I will accept the PR. Just know that if I have some feature I really want to add and it is Django 1.8+ only, then it will take precedence over keeping Django 1.7 compatibility.

coveralls commented 8 years ago

Coverage decreased (-33.6%) to 62.215% when pulling 5c1993f6f3b2782fc94c2041c3bb06a002ddc30d on ramusus:master into f1d4961b8993106a320499407cb9014a7db4e844 on grantmcconnaughey:master.

coveralls commented 8 years ago

Coverage decreased (-12.4%) to 83.442% when pulling d5d82473ee46ccc6d68b220e9983bc5105a061da on ramusus:master into f1d4961b8993106a320499407cb9014a7db4e844 on grantmcconnaughey:master.

coveralls commented 8 years ago

Coverage decreased (-0.9%) to 94.958% when pulling fb54467421b6c2564cdc853651096c2a2ab2cac7 on ramusus:master into f1d4961b8993106a320499407cb9014a7db4e844 on grantmcconnaughey:master.

coveralls commented 8 years ago

Coverage decreased (-0.8%) to 95.021% when pulling 79e61f077a2fd03252e35eabfd954c20b0970c15 on ramusus:master into f1d4961b8993106a320499407cb9014a7db4e844 on grantmcconnaughey:master.

ramusus commented 8 years ago

@grantmcconnaughey I fixed coveralls and travis issues, added tests. I didn't update documentation, because this functionality should be supported by default, I suppose. Check, please if it ready to merge

grantmcconnaughey commented 8 years ago

Awesome stuff, @ramusus. Give me the weekend to take a final look and write up some release notes.

grantmcconnaughey commented 8 years ago

django-field-history 0.5.0 has been deployed. Thanks for the work!