grantmcdermott / etwfe

Extended two-way fixed effects
https://grantmcdermott.com/etwfe/
Other
50 stars 11 forks source link

.Dtreat should be logical instead of integer #14

Closed grantmcdermott closed 1 year ago

grantmcdermott commented 1 year ago

... so that it automatically invokes marginaleffects::comparisons under the hood for emfx. (i.e. evaluates mean(.Dtreat==1 - mean(.Dtreat==0)instead ofmean(dYdX)`).

This won't make a difference for linear models, but will slightly change the results for non-linear families. So it's a bug fix.

Ironically, this was the default in the first iterations of the package. But I changed it whilst troubleshooting the jwdid difference in #4.