search

grantmcdermott / etwfe

Extended two-way fixed effects
https://grantmcdermott.com/etwfe/
Other
50 stars 11 forks source link

compatibility with marginaleffects 0.9.0 #20

Closed vincentarelbundock closed 1 year ago

vincentarelbundock commented 1 year ago

Apologies for the trouble, but version 0.9.0 of marginaleffects will break etwfe. Unfortunately, this means that you will receive an email asking you to upload a new version to CRAN very soon.

This PR fixes all compatibility issues I could notice, and makes the tests slightly more resilient to future issues.

One recommendation: avoid using the column name "group" as in test_baker.R. This is a "reserved" word in marginaleffects; I will build some guardrails in the future, but for now this is dangerous.

grantmcdermott commented 1 year ago

Merci @vincentarelbundock. Appreciate the heads-up and the proactive fix! Quick question before I merge: Have you submitted to CRAN yet?

vincentarelbundock commented 1 year ago

Yes, it's already submitted. Sorry this is so quick. I was pushed to submit by a revdep issue of my own, and didn't think about etwfe.

I'm not used to having people depend on my packages, but I'll try to have a revdep workflow on Github actions so we have more forewarning.