grantmcdermott / etwfe

Extended two-way fixed effects
https://grantmcdermott.com/etwfe/
Other
51 stars 11 forks source link

Error: Error in variable_classes[[v$name]] : subscript out of bounds #24

Closed JoepvanderPlas closed 1 year ago

JoepvanderPlas commented 1 year ago

When I follow the vignette and run the function emfx, I get the following error: Error in variable_classes[[v$name]] : subscript out of bounds

grantmcdermott commented 1 year ago

Which version of the package, etc? Please post your sessionInfo()

JoepvanderPlas commented 1 year ago

I am using version 0.3.0

grantmcdermott commented 1 year ago

Again, please post your sessionInfo() result.

Did you update marginaleffects recently? If so, there are some breaking changes that are fixed in the dev version. (A new CRAN submission is coming soon.) Can you try the dev version and see if the problem persists?

install.packages("etwfe", repos = "https://grantmcdermott.r-universe.dev")

Please restart your R session too.

vincentarelbundock commented 1 year ago

This is à marginaleffects error. I would also like to be sure that this is using the latest of both packages. If so, I'd love to see a simple replicable example using public data.

JoepvanderPlas commented 1 year ago

I re-installed the package using this: install.packages("etwfe", repos = "https://grantmcdermott.r-universe.dev")

And now it works! Thank you very much!

grantmcdermott commented 1 year ago

🎉