search

grantmcdermott / etwfe

Extended two-way fixed effects
https://grantmcdermott.com/etwfe/
Other
50 stars 11 forks source link

modelsummary 1.4.0 #31

Closed vincentarelbundock closed 1 year ago

vincentarelbundock commented 1 year ago

kableExtra does not appear to be actively maintained and it causes some problems on pkgdown websites and for installation on some platforms. In version 1.4.0, modelsummary will no longer depend on kableExtra. Instead it will give the user a choice to install any of the supported table-making package, and offer a function to set a persistent default.

Call setting:

modelsummary(model, output = "gt")

Persistent setting stays only for the current session:

options(modelsummary_factory_default = "gt")

Persistent setting stays across sessions:

config_modelsummary(factory_default = "gt")

Developers of packages that use modelsummary in vignettes need to add a table-making package to Suggests.

grantmcdermott commented 1 year ago

Thanks mate, appreciate the HU. I'll hold off on this for now until 1.4.0 hits CRAN. (Or does this this gt-based functionality already work well with the current CRAN version?)

vincentarelbundock commented 1 year ago

Yes, in principle this PR should be safe and work with past, present, and future versions of ˋmodelsummary‘.