search

grantmcdermott / etwfe

Extended two-way fixed effects
https://grantmcdermott.com/etwfe/
Other
51 stars 11 forks source link

safer test #36

Closed vincentarelbundock closed 1 year ago

vincentarelbundock commented 1 year ago

Snapshot-style tests should be avoided unless absolutely necessary, because as soon as anything changes they break.

marginaleffects 0.13.0 adds a new column to the output (S values) and breaks one of the expectations in test_xvar.R

grantmcdermott commented 1 year ago

Thanks!