search

grantmcdermott / tinyplot

Lightweight extension of the base R graphics system
https://grantmcdermott.com/tinyplot
Apache License 2.0
211 stars 7 forks source link

should pch and lty vary by group? #27

Closed grantmcdermott closed 1 year ago

vincentarelbundock commented 1 year ago

Personally, I think it would be a bad idea to have them vary automatically. Groups should be identified by one aesthetic dimension whenever possible. Otherwise the plot becomes very distracting.

However I do think it's about important to offer a simple way to change the aesthetic that varies. But we can already do that by setting col=1 and pch=1:ngrp.

This should probably be documented prominently.

grantmcdermott commented 1 year ago

Thanks @vincentarelbundock. Totally agree that these shouldn't vary by default. (The issue title isn't clear; my bad.) I was thinking instead of offering a convenience way for users to opt into this. I have a PR incoming shortly that I'll tag you as a reviewer for to look at.