search

grantmcdermott / tinyplot

Lightweight extension of the base R graphics system
https://grantmcdermott.com/tinyplot
Apache License 2.0
211 stars 7 forks source link

Fix y-title for function names #51

Closed etiennebacher closed 12 months ago

etiennebacher commented 12 months ago

Close #47. I didn't try on many plots myself but it looks like it passes the CI. Sorry for all for the git changes, I don't know why it's like this, the changes are just a few lines at the beginning of plot2.default().

@grantmcdermott I'm still struggling with the tests suite of this package (esp. because I'm currently on Windows) so it's probably better if you can take over this PR to generate snapshots.

New behavior:

set.seed(42)
plot(rnorm(1))


library(plot2)
set.seed(42)
plot2(rnorm(1))

grantmcdermott commented 12 months ago

Sorry for all for the git changes, I don't know why it's like this, the changes are just a few lines at the beginning of plot2.default().

Is it perhaps this? Or maybe something to do with your lintr?

Regardless, I'll take a look shortly. Thanks @etiennebacher!

etiennebacher commented 12 months ago

Is it perhaps this?

Thanks, I think it worked for future commits but I can't cancel for this PR

grantmcdermott commented 12 months ago

Excellent. Sorry to be a real pain but do you mind canceling this PR and trying again? (You probably have to clone a fresh version of the repo...)

If it is the crlf ending then I don't want to split the codebase and end up with large diffs each time 😬

etiennebacher commented 12 months ago

No worries