search

grantmcdermott / tinyplot

Lightweight extension of the base R graphics system
https://grantmcdermott.com/tinyplot
Apache License 2.0
226 stars 7 forks source link

Fix y-title for function names #52

Closed etiennebacher closed 1 year ago

etiennebacher commented 1 year ago

Same as #51, close #47

Much better like this @grantmcdermott

etiennebacher commented 1 year ago

What? No idea why it fails now

grantmcdermott commented 1 year ago

Super, thanks. I'll take a look on my local Linux machine as soon as the kids get to school.

grantmcdermott commented 1 year ago

Hmmm. It looks like the Hershey font tests (and one par restore test) are triggering the CI errors. It's almost certainly nothing to do with this PR, but I'd like to test a bit more locally. I have to jump on some other work first, but will circle back to this later.

etiennebacher commented 1 year ago

This fails only on R-devel, could it be due to a recent commit there? For example https://github.com/wch/r-source/commit/fa69bab0e61ceca6d186afe7c91f2d2b558db718?

grantmcdermott commented 1 year ago

This fails only on R-devel, could it be due to a recent commit there?

Thanks, I think that must be it. I downloaded the action artifact here and manually inspected the _tinysnapshot_review diffs. I honestly can't see what the difference is.... maybe some incredibly slight shading/alpha change? I'll wait for R 4.4.0 to re-generate these snapshots locally

At any rate, happy to accept the PR now. Thanks for the contribution @etiennebacher !