search

grantneale / kafka-lag-based-assignor

Kafka partition assignor that distributes lag evenly across a consumer group
Apache License 2.0
12 stars 5 forks source link

Add support for kafka 2.5.0 #5

Closed velo closed 4 years ago

velo commented 4 years ago

Not sure if project still active, decide to send a PR back before trying my own release =)

grantneale commented 4 years ago

Hi @velo, thank you for the PR. I would be happy to release this patch.

Please fix the checkstyle error, and ensure that mvn clean verify completes successfuly:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  3.889 s
[INFO] Finished at: 2020-06-30T14:17:29+09:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar (attach-javadoc) on project kafka-lag-based-assignor: MavenReportException: Error while generating Javadoc:
[ERROR] Exit code: 1 - kafka-lag-based-assignor-velo/src/main/java/com/github/grantneale/kafka/LagBasedPartitionAssignor.java:79: error: reference not found
[ERROR]  * @see PartitionAssignor
[ERROR]         ^
[ERROR]
[ERROR] Command line was:javadoc @options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in 'kafka-lag-based-assignor-velo/target/apidocs' dir.
[ERROR]
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
velo commented 4 years ago

Build is failing here to be signed with GPG, I think that is kinda success

grantneale commented 4 years ago

Thanks, that should do it.

grantneale commented 4 years ago

This will be included in release 2.0.0, which should be available on maven central soon.

velo commented 4 years ago

awesome, saw the release at central cheers