grantwilliams / wg-gesucht-crawler-cli

Python web crawler / scraper for WG-Gesucht. Crawls the WG-Gesucht site for new apartment listings and send a message to the poster, based off your saved filters and saved text
MIT License
76 stars 28 forks source link

Individualize template text #6

Open NexusReflex opened 5 years ago

NexusReflex commented 5 years ago

Added a new function 'substitute_name'. It replaces the string 'Submitter' inside the template text with the submitters first name. In case of the submitters name including a title (Herr/Frau) the title and full name are added instead. (edit: I couldn't get the travis test to run with python on osx and don't have a way of testing on linux at the moment)

cami0 commented 5 years ago

I tested pull request but the replacement of the string "Submitter" didn´t work

NexusReflex commented 5 years ago

hm, that's strange, it works for me. Does the test run successfully?

Be sure your message template looks something like: Hello Submitter, .....blabla...

cami0 commented 5 years ago

I tried but is not working. I erased everything and downloaded your pull request. Also used Hello Submitter, but Submitter doesn´t get replaced. I not sure about how can I run further testings. I would like to contribute if the request if possible. I look forward to further steps.

NexusReflex commented 5 years ago

Hi Cami0, could you give me a bit more details on what your running, how, and the exact error you get, please?

cami0 commented 5 years ago

Hello NexusReflex, I have Install Python and Anaconda Prompt in my Computer. I have also modifed the files of the master branch with your changes. Here is the result: https://www.dropbox.com/s/ygs630mjsj6hd4t/wg-gesucht-crawler-cli.rar?dl=0

But still is not working. At this Point I´m not sure about what is not working.

=> Are this files working for you?

Kind Regards

Camio