A new site I'd like you to consider blocking (Piped - piped.kavin.rocks)

grantwinney / hide-comments-everywhere

A browser extension for hiding major commenting systems like Disqus, Livefyre, Facebook plugin, WordPress, YouTube, etc.

MIT License

38 stars 6 forks source link

A new site I'd like you to consider blocking (Piped - piped.kavin.rocks) #103

Closed MrChocolatine closed 2 years ago

MrChocolatine commented 2 years ago

Here's a new site I'd like you to consider blocking:

piped.kavin.rocks

(please include any other relevant details)

What is Piped? https://github.com/TeamPiped/Piped

An alternative privacy-friendly YouTube frontend which is efficient by design.

Thank you.

Extension's information:

Addon version: 1.6.5
Definitions version: 138
Environment
- User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko)
- Chrome/100.0.4896.127 Safari/537.36
- Platform: macOS

grantwinney commented 2 years ago

Comments on that site are already being blocked, since any elements with a "comment" class applied to them are hidden by default. Is there a particular page where you're still seeing them?

MrChocolatine commented 2 years ago

Comments on that site are already being blocked, since any elements with a "comment" class applied to them are hidden by default. Is there a particular page where you're still seeing them?

Weird, on my side I see comments, for instance on this page:

https://piped.kavin.rocks/watch?v=bS4Q-WWyl3Q

And my whitelist is empty.

grantwinney commented 2 years ago

I don't see them on that page either. Hmm..

You're seeing the red "blocked" icon in the addon's popup window, right?
If you open the browser console and reload the page, do you see any errors?
On the "options" page for the addon, if you scroll down to the Info section there should be some stats about the addon.. posting those here might help.

MrChocolatine commented 2 years ago

Yes I see that icon, indicating comments should be blocked on that page.
Right, I forgot to check the console and look what I found.

Which is weird as, I can confirm you, the whitelist and blacklist textfields were empty, I never customised any settings for the extension.

I can see this error comes from here.
The extension's information are already in my initial post

I ended up uninstalling and reinstalling the extension (especially after seeing the error in the console), and now I can see the comments are blocked. The extension was not out-of-date, all the setting page is exactly the same as it was before reinstalling it (and same information about the versions).

I have no idea what happened ¯_(ツ)_/¯ ...

MrChocolatine commented 2 years ago

Feel free to close the issue if you want, as I am not sure we can investigate further, sorry for the noise.

grantwinney commented 2 years ago

Sorry I missed the details in the original post. That's odd. You had the latest version of the addon but it was failing to download the file that tells it what to hide. I'll probably dig around in the code to see what might've caused it to behave like that, but glad reinstalling it worked!