search

grantwinney / hide-comments-everywhere

A browser extension for hiding major commenting systems like Disqus, Livefyre, Facebook plugin, WordPress, YouTube, etc.
MIT License
38 stars 6 forks source link

Need to fix for www.reddit.com #185

Closed iJustErikk closed 5 months ago

iJustErikk commented 10 months ago

This extension no longer works at www.reddit.com. Seems like we could just target #comment-tree-content-anchor-XXXXX not sure if we do exact matches or if we can figure in prefixes as well.

Do we? If we don't, would anyone have any input if I were to implement these to work with prefixes?

Since we run into external compatibility issues, we could run weekly puppeteer + this extension tests and some links we know have comments (for public access platforms). Though, these tests may run into external compatibility if the website changes.

grantwinney commented 10 months ago

@iJustErikk I'm not having a problem with reddit (using edge on a laptop), but maybe it depends on the page or the view. Can you let me know of a thread that you're seeing comments on? Also, your browser and whether you're on mobile may help. Who knows how they might switch up the DOM depending on how you're using the site...

If there's an id that ends up being a more reliable match, even if the end of it changes, it's certainly doable. I've got other stuff in the sites.json file like that.

div[id^='comment-tree-content-anchor']
grantwinney commented 6 months ago

Now I see it. Okay, I've applied a fix. Try updating the definitions on the options page and see if it works better.