grapesmoker / qems2

A new implementation of the QEMS submission system for quizbowl questions.
GNU General Public License v2.0
9 stars 4 forks source link

Type questions tagging on VHSL set doesn't work #285

Closed mbentley00 closed 8 years ago

mbentley00 commented 8 years ago

Entering a category such as {Literature - American} on the Type Questions screen doesn't work for some reason. It works in other sets.

mweiner1 commented 8 years ago

This seems to work some of the time -- my initial guess was that if you don't spell the category exactly right, including using the right kind of dash, it will tag it as a category that doesn't exist; thus, it will show up as having a category on some screens but won't count against the needs for the real category. I don't know enough about the technical aspects of this to see if I'm right, but I can say that about 50% of the time, questions submitted through Type Questions work exactly as intended for me (they get a real tag and fulfill needs in a category) and the other 50% they appear tagged in some screens but not when you open edit question or look at category needs.

mweiner1 commented 8 years ago

Just for informational purposes, this still works with some categories but not others. It seems totally dependent on the specific subcategory rather than anything else (in a recent submission, all of my questions in particular subcategories got the correct tag, and none of my questions in other subcategories did, even though all questions were part of the same submission and formatted identically). I will update what behavior I see as I work through more subcats on the current set.

mbentley00 commented 8 years ago

What's an example set/category this happens for?

On Fri, Nov 27, 2015 at 5:02 PM, mweiner1 notifications@github.com wrote:

Just for informational purposes, this still works with some categories but not others. It seems totally dependent on the specific subcategory rather than anything else (in a recent submission, all of my questions in particular subcategories got the correct tag, and none of my questions in other subcategories did, even though all questions were part of the same submission and formatted identically). I will update what behavior I see as I work through more subcats on the current set.

— Reply to this email directly or view it on GitHub https://github.com/grapesmoker/qems2/issues/285#issuecomment-160232524.

mweiner1 commented 8 years ago

VHSL Conferences/Regionals 2016. I believe "Social Science - Social Criticism" correctly received the tags but "Social Science - Sociology" and "Social Science - Psychology" did not, even though the questions were mixed together in one Type Questions submission. Also, since I submitted that comment, it worked for both of the "Vocabulary" subcategories.

On Fri, Nov 27, 2015 at 8:42 PM, mbentley00 notifications@github.com wrote:

What's an example set/category this happens for?

On Fri, Nov 27, 2015 at 5:02 PM, mweiner1 notifications@github.com wrote:

Just for informational purposes, this still works with some categories but not others. It seems totally dependent on the specific subcategory rather than anything else (in a recent submission, all of my questions in particular subcategories got the correct tag, and none of my questions in other subcategories did, even though all questions were part of the same submission and formatted identically). I will update what behavior I see as I work through more subcats on the current set.

— Reply to this email directly or view it on GitHub <https://github.com/grapesmoker/qems2/issues/285#issuecomment-160232524 .

— Reply to this email directly or view it on GitHub https://github.com/grapesmoker/qems2/issues/285#issuecomment-160236981.

joellejay commented 8 years ago

Yeah, this is still a problem for "{Science - Biology}". There's also the issue that when you go to the "Recent Questions" page it appears that the questions are correctly tagged, but if you click on one of them it shows the default American Lit tag and the tally for the category doesn't update on the main page. The 2015 VHSL regionals set seemed to tag correctly, except it used "{Science - Science Biology}" (which also doesn't work in the 2016 set). Are the set-wide distribution entries for category and subcategory names not input correctly now?

Unrelated: the char count doesn't seem to be ignoring pronunciation guides.

mweiner1 commented 8 years ago

I put in the names with the redundant top-level categories last year because that helped with my manual packet-building procedure. Since as far as I know the system builds the packets now, it's no longer necessary (though maintaining distinctions like "Music" under Arts and "Popular Music" under Trash, and "General English Vocabulary" under Vocabulary as opposed to "Vocabulary" under Foreign Language, is still nice to have in case manual compilation is ever needed again -- basically, no two subcategories should have the exact same name, and always including the top-level category in the name was my dumb way of ensuring that). As far as I know the default in QEMS2 is to do it the other way and I didn't see any reason to mess with it this time around.

PGs do count towards question length in HSAPQ style, so that box was deliberately unchecked when the set was created. The box works as intended (it can be toggled and will either ignore the guides or not based on what you choose) so this is not a software bug.

On Sun, Nov 29, 2015 at 6:17 PM, joellejay notifications@github.com wrote:

Yeah, this is still a problem for "{Science - Biology}". There's also the issue that when you go to the "Recent Questions" page it appears that the questions are correctly tagged, but if you click on one of them it shows the default American Lit tag and the tally for the category doesn't update on the main page. The 2015 VHSL regionals set seemed to tag correctly, except it used "{Science - Science Biology}" (which also doesn't work in the 2016 set). Are the set-wide distribution entries for category and subcategory names not input correctly now?

Unrelated: the char count doesn't seem to be ignoring pronunciation guides.

— Reply to this email directly or view it on GitHub https://github.com/grapesmoker/qems2/issues/285#issuecomment-160480471.

mbentley00 commented 8 years ago

I'm pretty sure I've figured out what the problem is with categories. I think it's incorrectly matching against categories of the same name in other distributions. But I need to fix some bugs relating to upgrading to the latest version of django first so I can test this.

On Sun, Nov 29, 2015 at 3:37 PM, mweiner1 notifications@github.com wrote:

I put in the names with the redundant top-level categories last year because that helped with my manual packet-building procedure. Since as far as I know the system builds the packets now, it's no longer necessary (though maintaining distinctions like "Music" under Arts and "Popular Music" under Trash, and "General English Vocabulary" under Vocabulary as opposed to "Vocabulary" under Foreign Language, is still nice to have in case manual compilation is ever needed again -- basically, no two subcategories should have the exact same name, and always including the top-level category in the name was my dumb way of ensuring that). As far as I know the default in QEMS2 is to do it the other way and I didn't see any reason to mess with it this time around.

PGs do count towards question length in HSAPQ style, so that box was deliberately unchecked when the set was created. The box works as intended (it can be toggled and will either ignore the guides or not based on what you choose) so this is not a software bug.

On Sun, Nov 29, 2015 at 6:17 PM, joellejay notifications@github.com wrote:

Yeah, this is still a problem for "{Science - Biology}". There's also the issue that when you go to the "Recent Questions" page it appears that the questions are correctly tagged, but if you click on one of them it shows the default American Lit tag and the tally for the category doesn't update on the main page. The 2015 VHSL regionals set seemed to tag correctly, except it used "{Science - Science Biology}" (which also doesn't work in the 2016 set). Are the set-wide distribution entries for category and subcategory names not input correctly now?

Unrelated: the char count doesn't seem to be ignoring pronunciation guides.

— Reply to this email directly or view it on GitHub <https://github.com/grapesmoker/qems2/issues/285#issuecomment-160480471 .

— Reply to this email directly or view it on GitHub https://github.com/grapesmoker/qems2/issues/285#issuecomment-160481641.

mbentley00 commented 8 years ago

Fixed