grapesmoker / qems2

A new implementation of the QEMS submission system for quizbowl questions.
GNU General Public License v2.0
9 stars 4 forks source link

Editing a question after the checkbox has been checked un-checks it, this is not desirable #381

Open mweiner1 opened 3 years ago

mweiner1 commented 3 years ago

Right now it looks like if a question is marked "edited" and someone then makes further changes to it using general editor-level access to the set (as opposed to, e.g., while checking the "proofread" box) this will remove its status as "edited."

Possibly this is intentional (to allow the editor to look at the question again and approve whatever new changes were made?) but it causes several undesirable consequences: In the CSV output it now shows EDITED = FALSE, there's no way to distinguish it from a question that has never been edited at all, this interferes with attempts to use this value to track set progress. If someone goes back in later and marks the box to try to address the above issue, that person is now shown as the "editor" of the question. This interferes with tracking credit/payment, etc. *The field on the pages that show recent questions, all questions, etc will show a last edited time for questions that are "unedited" - the main use of this field is to sort questions by whether they have a last edited time at all (as distinguished from a last revised time which is separately tracked here) to identify which questions need editing, so it should always match the TRUE/FALSE status of the "edited" flag.

mweiner1 commented 1 year ago

This appears to have been fixed.