Closed mbentley00 closed 9 years ago
That is very, very, very untrue. HSAPQ editors need to move questions to "holding pens" and other sets we edit all the time -- in no sense do we own the sets. You could probably get away with restricting this to "editor and up" in the origin set and "editor and up" in the destination set, but "owner and up" is not going to work.
There are use cases besides HSAPQ. I'm not saying this is not a useful function, I'm saying some care needs to be given to permissions so that people aren't just randomly moving questions around and then finding themselves unable to access them.
On Sun, Nov 30, 2014 at 7:40 PM, Theta91 notifications@github.com wrote:
That is very, very, very untrue. HSAPQ editors need to move questions to "holding pens" and other sets we edit all the time -- in no sense do we own the sets. You could probably get away with restricting this to "editor and up" in the origin set and "editor and up" in the destination set, but "owner and up" is not going to work.
— Reply to this email directly or view it on GitHub https://github.com/grapesmoker/qems2/issues/88#issuecomment-65008156.
I agree that you shouldn't just be able to move questions into another set willy-nilly. I think someone who is an editor in both sets should be able to do that. And the way you can make the HSAPQ situation work is to create a set called "HSAPQ Holding Pen" where HSAPQ makes the appropriate people editors of that set. Then they're able to move stuff in and out.
Are you saying that it might be hard given the current permission model to figure out if someone is an editor of a different set than the current one?
There are indeed use cases aside from HSAPQ, but a lot of ideas that've been talked about in the Issues have resulted in someone proposing a solution that only works for an individual set (a collegiate set like PADAWAN) and not a solution that works for groups that work on one or more sets over multiple years (HSAPQ, PACE, but also things like Penn Bowl, HFT, etc.).
There are better ways to restrict access than giving it JUST to owners of a set -- for example, sets can fall under "groups" (as they did in QEMS1.0). All HSAPQ's sets can be in the HSAPQ group and questions can be moved between HSAPQ sets by "editors and up". Same goes for NSC and such. Or even the much looser "editors and up" on both sets, but "owners and up" is just not the right policy.
Confirming that a "holding pen" set, with the ability for some in-charge people to move unneeded or extra questions into it from a main set they're also working on, is also something PACE will want/need for spare NSC questions that can be carried over year-to-year.
I've implemented the ability to move tossups and bonuses from a set you're the editor for to another set you have editor permissions for. I don't plan on implementing a special holding pen at the moment. You can effectively do this by creating a new set called "HSAPQ holding pen" and giving the appropriate people permission.
The problem with this is that you may not own the target set and therefore should not have the right to move a question to it. So this is going to have to be limited to sets that you own.