graph-genome / component_segmentation

Read in ODGI Bin output and identify co-linear components
Apache License 2.0
3 stars 4 forks source link

#21: use binary search to make things faster in populate_component_ma… #26

Closed dimatr closed 4 years ago

dimatr commented 4 years ago

…trix

josiahseaman commented 4 years ago

I'm a big fan of binary search. Is this PR ready for review?

dimatr commented 4 years ago

yes, please.

subwaystation commented 4 years ago

This looks really good, thank you @dimatr. I checked the MD5 sums of an example run output of master and your branch and they match perfectly. I can also report a speed improvement of at least 13x fold.