Closed lomereiter closed 4 years ago
It's really encouraging to see progress here. I heard we're seeing a 30x speedup in load times. Just ping me when this is ready for review. I've got a whole dashboard of notifications, so I don't always notice right away. I wrote component_segmentation, so I know it well.
OK, this is ready for review. I'll create a separate issue for segment_matrix
overhaul.
Summary of changes:
utils.path_dividers
vectorized binary search does all the job (np.searchsorted
)find_dividers
now returns a pandas dataframe (from, to, path) instead of two nested sets;segment_matrix
, though (five lines of code)discard_useless_links
function as it's dead code